Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for missing files before export #1005

Merged
merged 1 commit into from Jan 15, 2021

Conversation

bmatherly
Copy link
Member

Fix #990: When deleting a source file, nothing alterts me when
exporting that a source file is missing

src/docks/encodedock.cpp Outdated Show resolved Hide resolved
src/docks/encodedock.cpp Outdated Show resolved Hide resolved
src/docks/encodedock.cpp Show resolved Hide resolved
Copy link
Member Author

@bmatherly bmatherly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also considered moving the entire check up into the main application and adding a menu option so that the user can run the check whenever they want. But then I thought that we already do the check every time the file is opened. So that should be good enough. But, unfortunately, that means that the only way a user can trigger a repair is to close and reopen a project.

What are your thoughts about moving it into the main application?

src/docks/encodedock.cpp Outdated Show resolved Hide resolved
src/docks/encodedock.cpp Show resolved Hide resolved
@bmatherly
Copy link
Member Author

@ddennedy Another thought occurred to me. Would it work to scan the auto-save file before exporting? Upon clicking the export button, Shotcut could create a new auto-save file and scan that. But I do not know if an auto-save file always exists. Thoughts?

@ddennedy
Copy link
Member

The autosave file approach would not be sensitive to the Export > From field as you have it now.

@bmatherly
Copy link
Member Author

The autosave file approach would not be sensitive to the Export > From field as you have it now.

That is true. It would be checking the entire project as it does when a project is opened. I guess there are pros and cons to that.

Fix mltframework#990: When deleting a source file, nothing alterts me when
exporting that a source file is missing
@ddennedy ddennedy merged commit 4403bf3 into mltframework:master Jan 15, 2021
@ddennedy ddennedy added this to the next release milestone Jan 15, 2021
@bmatherly bmatherly deleted the unlinked_export branch February 1, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When deleting a source file, nothing alterts me when exporting that a source file is missing
2 participants