Warn the user before exporting a frame from proxy file #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddennedy
requested changes
Jul 6, 2021
|
Do you have an opinion about whether this should be a QuestionBox or a WarningBox? |
I think either one can work. |
ddennedy
reviewed
Jul 7, 2021
bmatherly
force-pushed
the
proxy_export_frame_prompt
branch
from
759be5e
to
563b288
Compare
ddennedy
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here:
https://forum.shotcut.org/t/add-warning-when-exporting-frame-with-proxy-on/28185