Fix erratic keyframe parameter height zoom function #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmatherly
requested changes
Nov 23, 2021
| @@ -30,6 +30,11 @@ Item { | |||
|
|
|||
| signal clicked(var keyframe, var parameter) | |||
|
|
|||
| function setLowestHighest(lh) { | |||
There was a problem hiding this comment.
Name suggestions:
Change "setLowestHighest" to "setMinMax"
Change "lh" to "zoomHeight"
thoughts?
There was a problem hiding this comment.
Yeah, I have no problem with changing names.
Updated with two commits below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a parameter's
minimumandmaximumproperties are constantly changing as I move a keyframe whilezoomHeightistrue.I made
minimumandmaximumproperty modification one-time event in response to a click on the zoom icon.zoomHeightcan be made to be a property of a parameter rather than of a parameter head as it was in the original.