Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registers the .mlt file name extension and associate it with shotcut.exe #1237

Merged
merged 2 commits into from Mar 5, 2022
Merged

Conversation

timlau
Copy link
Contributor

@timlau timlau commented Mar 4, 2022

I have added initial .mlt file assoiation to the windows NSIS installer

I don't have a windows system to test on at the moment, but is be easy to test and not break anything

Copy link
Member

@ddennedy ddennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I can confirm it is working with some small changes.

packaging/windows/shotcut.nsi Outdated Show resolved Hide resolved
packaging/windows/shotcut.nsi Outdated Show resolved Hide resolved
@timlau
Copy link
Contributor Author

timlau commented Mar 5, 2022

I have solved the issues and made a minor change to the naming uses Shotcut.mlt instead of Shortcut, It is the naming style than most application uses. Ex. .7z uses 7Zip,7z

@ddennedy
Copy link
Member

ddennedy commented Mar 5, 2022

change to the naming uses Shotcut.mlt

OK, yes I see that too in registy, but then I thought how with the "Type" appear in Explorer? I do not want it to show "Shotcut.mlt". I looked in Explorer, and I see it is showing "MLT XML," but I cannot find that anywhere in the registry?! Where is it getting this. I needed to uninstall the Microsoft Store app to test this properly. Ah, I see in my AppxManifest.xml to make the store app, I register the file association and set the "DisplayName" to MLT XML along with a logo.

image

It must be caching that info somewhere. Well, I am not going to reboot just to see if that changes things.

@ddennedy ddennedy merged commit 4559a30 into mltframework:master Mar 5, 2022
@ddennedy ddennedy added this to the v22.03 milestone Mar 5, 2022
@timlau timlau deleted the win-asso branch March 17, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants