Add Align to Reference option in timeline #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, just to let you know I have been waiting to see if I will make a 22.04 bug fixes release before merging this (and my glaxnimate MLT producer). |
Thanks for letting me know. It is OK with me if this request waits for a while. I am currently working on "phase 2". This request does not need to wait for phase 2, but if I finish phase 2 before this PR is merges, then I will add to it. Do you have any comments about the UI or the usability? I would like to resolve usability comments before it is merged. |
bmatherly
force-pushed
the
align_to_reference
branch
from
b12fb7a
to
ecb74a8
Compare
This is now implemented |
ddennedy
requested changes
Apr 29, 2022
Also fix clips with in/out point set.
Do not attempt to align clips if the quality is below the threshold
Fix code style Fix label capitalization
bmatherly
force-pushed
the
align_to_reference
branch
from
ecb74a8
to
9908273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is phase 1 of the "Align to Reference" feature.
This phase allows multiple timeline clips to be selected. The user selects the reference track to align to. Clips can only be aligned to a track and not to a specific clip. If a clip is on the reference track, it will be flagged as an error. An undo command allows the entire change to be reverted with undo.
This adds a project link dependency to fftw3 (which is already available in our builds)
Demo:
align_demo.mp4
Future phases:
2) Quality threshold to detect clips that can not be aligned. In Phase 1, unrelated clips will still find some alignment (even though there really is none)
3) Drift compensation - automatically apply a speed factor to a clip to correct cameras that record at different rates (some code for this exists, but it is not ready for testing)