Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler focus workaround #132

Merged
merged 2 commits into from
Oct 27, 2015

Conversation

metellius
Copy link
Contributor

Because the focusObjectChanged is not emitted correctly for qquickwidget, this
commit throws away the ForwardingQuickViewWorkaround hack and instead does it
through a single event filter installed on the QWidgetWindow (ie. native handle

The event print mechanism that I have been using a lot for debugging where key events go is also included in this PR.

Because the focusObjectChanged is not emitted correctly for qquickwidget, this
commit throws away the ForwardingQuickViewWorkaround hack and instead does it
through a single event filter installed on the QWidgetWindow (ie. native handle
for QMainWindow).
@metellius
Copy link
Contributor Author

This is broken for me in master, and fixed by this workaround:
Click a clip in timeline, then click the middle of the glwidget. Pressing left/right will not move the clip forward/backward.

Things to test:

  • Click timeline (clip in qquickwidget gets focus), then click up/down (keypress should be ignored, and reach all the way up to mainwindow where it changes active track)
  • Focus timeline, press up/down and check same as above. Then have shotcut lose focus by clicking on another application, then reactivate it by clicking window bar only, and check that up/down still works.

@ddennedy ddennedy merged commit 7231fa4 into mltframework:master Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants