Fix build for systems that have an unsupported version of QT5 installed #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddennedy
added a commit
that referenced
this pull request
Jul 30, 2014
Fix build for systems that have an unsupported version of Qt 5 installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for this issue:
https://plus.google.com/u/0/102032883547463415401/posts/dFiKM9Nc6Px?cfem=1
The user has Qt 5.3.0 installed. The script detects the installed version and does not use the version installed in his home directory.
I feel that this is a valid solution because we maintain Shotcut in a way that it requires a very specific version of Qt. Alternately, we could check if the supported version of QT is installed in the system path and only use the installed QT if it is the supported QT version.
The reason I haven't seen this problem in Ubuntu is because Ubuntu installs QT 5.2.1with qmake named "qmake" not "qmake-qt5". So the script does not detect the installed version of QT in my ubuntu installation.