Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading of binary lua files #206

Closed
wants to merge 1 commit into from

Conversation

allight
Copy link

@allight allight commented Jun 7, 2021

This is useful for some testing applications.

@allight
Copy link
Author

allight commented Jun 7, 2021

Failures seem to be the same ones that appear running cargo test on master.

@jugglerchris
Copy link
Collaborator

Hi,
Thanks for the contribution!
However it's deliberate that load_chunk doesn't load binary/compiled lua files, so this can't be merged as is.
The intention (which hasn't happened yet) is to add a new, unsafe API which does allow loading binary Lua files. See #116 and #145 for some previous discussion.
I think a method on Chunk like:

pub unsafe fn into_function_unsafe(self) -> Result<Function<'lua>>

seems reasonable, but I'd be interested in whether you think that works for your use case.

I'll look into why the CI is failing.

@jugglerchris
Copy link
Collaborator

FWIW I've fixed the CI issues (which I raised separately as #207).

@jugglerchris jugglerchris added this to the Version 1.0 milestone Jul 11, 2021
@jugglerchris
Copy link
Collaborator

This has been addressed as part of #236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants