Modernize dependencies #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove gulp/gulpfile in favor of package.json scripts (gulp-istanbul issues) - Update eslint, rules, and fix linter errors - Update webpack and config - Update babel - Update istanbul/nyc - Add jsdoc config - Update runtime dependencies (lodash and debug)
|
This is great. Really appreciate you taking the time to update this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @mlucool
I noticed this library in https://github.com/libp2p/js-libp2p (it's currently inlined), and I wanted to use it.
I cloned locally, but noticed that the dev dependencies were old and the project no longer built.
This is a PR to update the dependencies with minimal changes.
Unfortunately, gulp dependencies have not been updated to work with these latest versions (I believe the biggest issue was with istanbul). So gulp has been removed in favor of using each tool's cli directly.
Changes:
issues)