Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shell support #28

Closed
wants to merge 1 commit into from
Closed

Conversation

robingoth
Copy link

@robingoth robingoth commented May 4, 2022

I'm using zsh and run AWS CLI in a Docker container. ssm-session wasn't working for me, so I added shell support here

@mludvig
Copy link
Owner

mludvig commented Jun 25, 2022

Hey, thanks for the pull request. Does that mean that Python's os.system() doesn't work on zsh-based installations? That's odd...

@robingoth
Copy link
Author

It is using /bin/sh by default as I understood

@mludvig
Copy link
Owner

mludvig commented Jun 25, 2022

Hey, can you try if the latest master version works for you? I have switched from os.system() to os.execvp() in 93d5b2a and I hope that it helped. Let me know plz. Thanks!

@mludvig
Copy link
Owner

mludvig commented Aug 6, 2022

Didn't hear back. I assume that it works.

@mludvig mludvig closed this Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants