Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum cmake version stated in manual #424

Merged
merged 11 commits into from
Feb 27, 2023
Merged

Update minimum cmake version stated in manual #424

merged 11 commits into from
Feb 27, 2023

Conversation

SHervoe-Hansen
Copy link
Collaborator

@SHervoe-Hansen SHervoe-Hansen commented Feb 1, 2023

Description

Cmake versions 3.22 >= x >= 3.20 will all yield the error:

CMake Error at /usr/share/cmake/Modules/ExternalProject.cmake:2746 (message):
  URL_HASH is set to

    SHA256=48986b507497f027e4fa1144a08c2d0b6d81fb476fad024956f8104448ca9ad8;DOWNLOAD_EXTRACT_TIMESTAMP;true

  but must be ALGO=value where ALGO is

    MD5|SHA1|SHA224|SHA256|SHA384|SHA512|SHA3_224|SHA3_256|SHA3_384|SHA3_512

  and value is a hex string.

@SHervoe-Hansen SHervoe-Hansen added bug 🐛 Broken or wrong functionality fix 🔧 Fix broken functionality and removed bug 🐛 Broken or wrong functionality labels Feb 1, 2023
Copy link
Owner

@mlund mlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm not able to reproduce the error on my macos system with cmake 3.25.2. Could you describe how the current version fails?

@SHervoe-Hansen
Copy link
Collaborator Author

SHervoe-Hansen commented Feb 18, 2023

I can reproduce the error on a Linux system with cmake v. 3.20.2 (Faunus manual states minimum 3.16+) and yields the error message first stated.

I have furthermore attempted to update cmake to v. 3.22.1 and it still yields the same error stated originally.

@SHervoe-Hansen
Copy link
Collaborator Author

SHervoe-Hansen commented Feb 18, 2023

Okay so I upgraded cmake to 3.25.2 and now it works without errors.

I will change the PR to change the manual so that it states Faunus requires minimum cmake v. 3.25.

A rebase might be necessary.

@SHervoe-Hansen SHervoe-Hansen changed the title Fixed trompeloeil having wrong URL_HASH check Update minimum cmake version stated in manual Feb 18, 2023
@mlund mlund merged commit e137e86 into master Feb 27, 2023
@mlund mlund deleted the ExternalTools branch February 27, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🔧 Fix broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants