Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements evaluate #73

Merged
merged 28 commits into from Sep 15, 2021
Merged

Implements evaluate #73

merged 28 commits into from Sep 15, 2021

Conversation

dfalbel
Copy link
Member

@dfalbel dfalbel commented Aug 26, 2021 •
edited

This PR has taken a small detour and we are now implementing checking for ctx assignments too.
The idea is to be able to simplify the fitted object so evaluate and predict can create their own new context that would never modify the fitted object by accident.

  • The context object is no longer retained after training: this allows us to keep the output much cleaner as well as having better control on what is accessible in the output.
  • The context object is now locked: it's harder to make strange assumptions regarding the context.
  • Context fields are now active fields and we provide checks for the most important ones.
  • We have implemented an evaluate function that allows evaluating a fitted model.

@dfalbel
Factor out the ctx preparation for validation.
51adecf
@dfalbel
Factor out the valid_loop as a function of ctx and step.
e57aea2
@dfalbel
Refactor step acquisition.
9c6743a
@dfalbel
Move cleaning context code to the context class.
1fd096c
@dfalbel
Lock the ctx objects so users can't add elements to it.
663ce6a
@dfalbel
Start adding checks for ctx attributes. This will allow for more ma…
d67668e 
…intainable code.
@dfalbel
make a single source of truth for input, target and batch.
e600c82
@dfalbel
Check when assigning epochs to context.
e5c09ae
@dfalbel
move even more checks to the context object
8f086c6
@dfalbel
Get metrics back to the root of callbacks.
0e51a2d
@dfalbel
Refactor context initialization. Now fully delegating to initialize…
9620776 
… methods of specialized classes.
@dfalbel
Simplified the fitted model output.
b7a8bc2
@dfalbel
Run devtools::document().
7f283a4
@dfalbel
Improve context cleanup.
f4a83b9
@dfalbel
Remove objects from the enclosing environment that leaks.
cd3c3c9
@dfalbel
add evaluate tests and print method
29deaab
@dfalbel
tweak metric name
6dc8050
@dfalbel
fix error message
838be0b
@dfalbel
update plot
375394a
@dfalbel
Document the evaluate function.
91d753c
@dfalbel
Fix missing argument in get_metrics
83d9634
@dfalbel
sprinf -> sprintf
8e0d903
@dfalbel
refer to records directly and add test
b697acb
@dfalbel
improve documentation for evaluate.
7818377
@dfalbel
add exit handlers to avoid large leaks due to #74
8212e8a
skeydan
skeydan approved these changes Sep 15, 2021
View reviewed changes
Copy link

@skeydan skeydan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! The evaluate() functionality is super useful.

@dfalbel dfalbel merged commit 4b8ba20 into master Sep 15, 2021
@dfalbel dfalbel deleted the feature/evaluate branch September 15, 2021 18:42
@dfalbel dfalbel mentioned this pull request Sep 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeydan skeydan skeydan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dfalbel @skeydan