Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: update protobuf #42

Merged
merged 1 commit into from
May 6, 2024
Merged

Windows: update protobuf #42

merged 1 commit into from
May 6, 2024

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Jan 25, 2024

This updates the version of protobuf on windows to add support for the new arm64 hardware. Same setup as CRAN version of protolite.

@jeroen jeroen force-pushed the main branch 2 times, most recently from d720100 to aa41e08 Compare January 25, 2024 21:37
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8032d2f) 94.38% compared to head (aa41e08) 64.96%.
Report is 1 commits behind head on main.

❗ Current head aa41e08 differs from pull request most recent head 29eaa47. Consider uploading reports for the commit 29eaa47 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
- Coverage   94.38%   64.96%   -29.43%     
===========================================
  Files          23       23               
  Lines        1176     1176               
===========================================
- Hits         1110      764      -346     
- Misses         66      412      +346     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfalbel dfalbel merged commit 5aecf6f into mlverse:main May 6, 2024
3 of 5 checks passed
@dfalbel
Copy link
Member

dfalbel commented May 6, 2024

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants