Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch_first arg for attention. #828

Merged
merged 5 commits into from
May 25, 2022
Merged

Conversation

jonthegeek
Copy link
Contributor

I haven't tested this; Rstudio crashed when I tried to build torch locally. Theoretically it's straightforward, but I'd definitely like to test it before I call this done. Any help is appreciated!

@dfalbel
Copy link
Member

dfalbel commented May 13, 2022

To build torch locally you will need to run source('tools/buildlantern.R'). THen devtools::load_all() should just work.

@jonthegeek
Copy link
Contributor Author

I'm getting a bunch of errors like this: c++.exe: error: C:/rtools42/permissive: No such file or directory

Evidently some make vars are getting misinterpreted.

It may be time for me to finally learn about this WSL thing to run Linux on a Windows machine...

@dfalbel
Copy link
Member

dfalbel commented May 17, 2022

Hmm, I haven't seen those errors. Might be a problem with Rtools?
Or maybe you will need to install the visual studio c++ compiler . I'll review this PR tomorrow!

@jonthegeek
Copy link
Contributor Author

I was able to install this branch with install_github, so it's specifically something about sourcing that makes rtools act up. I'll keep poking at it, but I can use this workaround to try to actually sort out tests tomorrow.

@dfalbel
Copy link
Member

dfalbel commented May 25, 2022

Fix #829

@dfalbel dfalbel merged commit 7ff632e into mlverse:main May 25, 2022
@jonthegeek jonthegeek deleted the batch-first branch September 8, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants