Simplify R7 classes #452
Merged
Simplify R7 classes #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into simplify-r7-class
dfalbel
added a commit
that referenced
this pull request
Jan 24, 2021
dfalbel
added a commit
that referenced
this pull request
Jan 24, 2021
fix help handler broken in #452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will simplify R7 classes so they are just a single object, in our case, a simple external pointer, so it's easy to make R7 classes directly from C++ - which is going to help in #451 .
This is will be a breaking change for anyone that is using tensors as environments, and thus, saving other obejects there. (like we are doing in the optimizers).