-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ScriptModule and methods #593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfalbel
added
the
lantern
Use this label if your PR affects lantern so it's built in the CI
label
Jun 16, 2021
plumbing to allow querying parameters of a saved ScriptModule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure to:
jit_trace
strips names from lists of tensors #537ScriptModule
R7 class andnn_Module
so we only need to provide the basic types and all the rest is managed by the same code base.script$modules
are also callableself$parameters_[[name]]
correctly calls theregister_parameter
method.Refactor the conversion from
SEXP
totorch::jit::Stack
:IValues
XPtrTorch
subclasses for IValues and operators to convert from and toSEXP
soperator::SEXP()
for XPtrTorchstring and support IValue <-> R character vector.jit_scalar
wrapper and convert length 1 numeric vectors to lists