Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade LibTorch to v1.10.1 #758

Merged
merged 20 commits into from Feb 2, 2022
Merged

Conversation

hsbadr
Copy link
Collaborator

@hsbadr hsbadr commented Jan 16, 2022

Closes #751 and #744.

  • Update LibTorch to version 1.10.1
  • Use CUDA 11.3 with LibTorch 1.10.1
  • Update GitHub Actions, including lantern builds
  • Re-generate declarations.yaml for LibTorch 1.10.1
  • Re-generate C++ code for LibTorch 1.10.1
  • Update lantern for LibTorch 1.10.1
  • Style and render documents
  • Run unit tests
  • Run reverse dependency checks
  • Add NEWS bullet

@dfalbel I need your help on the lantern side.

@hsbadr hsbadr force-pushed the libtorch-1.10.1 branch 3 times, most recently from 83d568e to e4bbd95 Compare January 17, 2022 02:57
@hsbadr
Copy link
Collaborator Author

hsbadr commented Jan 17, 2022

@dfalbel torchgen doesn't handle c10::string_view or when argument$dynamic_type is parsed as ::std::array<bool,N>.

@dfalbel dfalbel added the lantern Use this label if your PR affects lantern so it's built in the CI label Jan 17, 2022
@dfalbel
Copy link
Member

dfalbel commented Jan 17, 2022

Thanks @hsbadr
Yeah, sometimes this happens, we will need to add lantern and wrapper types to handle them. I can work on that soon!

@dfalbel
Copy link
Member

dfalbel commented Jan 26, 2022

@hsbadr I think most (if not all) of Rcpp/Lantern wrappers are working now. There are still a few tests failing though if you want to investigate.

@dfalbel dfalbel changed the base branch from master to libtorch1.10 February 2, 2022 11:56
@dfalbel
Copy link
Member

dfalbel commented Feb 2, 2022

/style

@dfalbel dfalbel merged commit 800086f into mlverse:libtorch1.10 Feb 2, 2022
@hsbadr
Copy link
Collaborator Author

hsbadr commented Feb 4, 2022

I think most (if not all) of Rcpp/Lantern wrappers are working now. There are still a few tests failing though if you want to investigate.

Sorry, I haven't been available to work on this.

@dfalbel
Copy link
Member

dfalbel commented Feb 4, 2022

No worries @hsbadr , thank you very much for getting this started!!

@hsbadr hsbadr deleted the libtorch-1.10.1 branch February 5, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lantern Use this label if your PR affects lantern so it's built in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade LibTorch to v1.10.1
2 participants