Fix maxWords method to include the upper bound, not exclude it. Fixes j…

…query-validation#284
mlynch · Mar 29, 2012 · 85b719b · 85b719b
1 parent f2f8bcf
commit 85b719b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/additional-methods.js b/additional-methods.js
@@ -20,7 +20,7 @@
 		.replace(/[0-9.(),;:!?%#$'"_+=\/-]*/g,'');
 	}
 	jQuery.validator.addMethod("maxWords", function(value, element, params) {
-	    return this.optional(element) || stripHtml(value).match(/\b\w+\b/g).length < params;
+	    return this.optional(element) || stripHtml(value).match(/\b\w+\b/g).length <= params;
 	}, jQuery.validator.format("Please enter {0} words or less."));
 
 	jQuery.validator.addMethod("minWords", function(value, element, params) {

diff --git a/test/methods.js b/test/methods.js
@@ -527,8 +527,10 @@ test("maxWords", function() {
 	ok( method("hello", 2), "plain text, valid" );
 	ok( method("<b>world</b>", 2), "html, valid" );
 	ok( method("world <br/>", 2), "html, valid" );
-	ok( !method("hello worlds", 2), "plain text, invalid" );
-	ok( !method("<b>hello</b> world", 2), "html, invalid" );
+	ok( method("hello worlds", 2), "plain text, valid" );
+	ok( method("<b>hello</b> world", 2), "html, valid" );
+	ok( !method("hello my world", 2), "plain text, invalid" );
+	ok( !method("<b>hello</b> my world", 2), "html, invalid" );
 });
 
 test("pattern", function() {