Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Either legend is wrong or bullet points are wrong #4

Closed
volker48 opened this issue Mar 20, 2018 · 2 comments
Closed

Either legend is wrong or bullet points are wrong #4

volker48 opened this issue Mar 20, 2018 · 2 comments

Comments

@volker48
Copy link

In the selection section these bullet points don't match the graph according to the legend.

  • loc and query selections are identical in performance.
  • Square bracket selection is the slowest method.

According to the graph it looks like loc and square brackets are identical in performance. It looks like query is the slowest method. I'm not sure if the issue is with the legend in the graph or the bullet points.
mm-mansour pushed a commit that referenced this issue Mar 22, 2018
Edited bullet points in section 1.3 in README, fixes issues #4
921a484
@mm-mansour
Copy link
Owner

The codes for query selection and bracket selection were swapped as reported in #1 . The code and the plot were fixed; however, I forgot to fix the bullet points. I just did.

@volker48
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@volker48 @mm-mansour