Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported some time ago [1], some PS interpreters have issues with the CSA code lcms2 emits
when gamma tables are encountered in the icc profile. This patch picks up the ideas from the
mentioned mailing list thread and implements them in lcms2.
Testing happened mostly with the icc profiles provided directly in the testbed folder and those generated by the testcms program. The results are all parseable by ghostscript. It should not be left unmentioned that this does not cover the modified code path in
EmitCIEBasedDEF
! It would be nice if somebody with an appropriate icc profile could test that one.Generally it would be nice if we could merge this patch (or some other solution) into lcms2, since this is still a show stopper for a proper adoption of lcms2 in the PS output device of the poppler library [2]. The latter is not only central to the pdf-printing support within the Okular pdf viewer, but through the cups-filters [3] also central to linux printing as a whole.
[1] https://sourceforge.net/p/lcms/mailman/message/33182987/
[2] https://gitlab.freedesktop.org/poppler/poppler/issues/125
[3] https://github.com/OpenPrinting/cups-filters/blob/master/filter/pdftops.c#L504