Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PostScript CSA Generation #214

Merged
merged 1 commit into from
May 16, 2020
Merged

Cleanup PostScript CSA Generation #214

merged 1 commit into from
May 16, 2020

Conversation

d1saster
Copy link
Contributor

As reported some time ago [1], some PS interpreters have issues with the CSA code lcms2 emits
when gamma tables are encountered in the icc profile. This patch picks up the ideas from the
mentioned mailing list thread and implements them in lcms2.

Testing happened mostly with the icc profiles provided directly in the testbed folder and those generated by the testcms program. The results are all parseable by ghostscript. It should not be left unmentioned that this does not cover the modified code path in EmitCIEBasedDEF! It would be nice if somebody with an appropriate icc profile could test that one.

Generally it would be nice if we could merge this patch (or some other solution) into lcms2, since this is still a show stopper for a proper adoption of lcms2 in the PS output device of the poppler library [2]. The latter is not only central to the pdf-printing support within the Okular pdf viewer, but through the cups-filters [3] also central to linux printing as a whole.

[1] https://sourceforge.net/p/lcms/mailman/message/33182987/
[2] https://gitlab.freedesktop.org/poppler/poppler/issues/125
[3] https://github.com/OpenPrinting/cups-filters/blob/master/filter/pdftops.c#L504

As reported some time ago [1], some PS interpreters have issues with the CSA code lcms2 emits
when gamma tables are encountered in the icc profile. This patch picks up the ideas from the
mentioned mailing list thread and implements them in lcms2.

[1] https://sourceforge.net/p/lcms/mailman/message/33182987/
@mm2
Copy link
Owner

mm2 commented May 16, 2020

Fantastic!
I did some work in this direction, but your changes does include all I was planning and even more.
I would like to add your name in the list of contributors, it is that ok to you? What name should i put? or you prefer the nickname?

@mm2 mm2 merged commit 036916a into mm2:master May 16, 2020
@d1saster
Copy link
Contributor Author

Wow, that was a fast merge :) You can use my real name (Philipp Knechtges), if you want, for the contributors list. But let me also take the opportunity to thank you for the incredible work you did over the years to start such a cool project and keep it going for such a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants