Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Test Results File" parameter doesn't allow wildcards while Pickles does allow them #2

Closed
dvdvorle opened this issue Nov 27, 2018 · 3 comments

Comments

@dvdvorle
Copy link
Contributor

The task is more restrictive than Pickles itself when it comes to wildcards. If the name of the result file is not fully known this task cannot be used.

Since the default Azure Devops task "Visual Studio Test" generates the result file name based on the time this makes it harder than necessary to use.

@dvdvorle dvdvorle changed the title The Test Results File parameter doesn't allow wildcards while Pickles does allow them The "Test Results File" parameter doesn't allow wildcards while Pickles does allow them Nov 27, 2018
dvdvorle added a commit to dvdvorle/PicklesGeneratorTask that referenced this issue Nov 27, 2018
dvdvorle added a commit to dvdvorle/PicklesGeneratorTask that referenced this issue Nov 27, 2018
@mmajcica
Copy link
Owner

More than removing the assert I would like to implement a find file method from the task sdk.
Something like here
https://github.com/mmajcica/DeploySsis/blob/ee5b285f998f7cd050e56f7c12bea520dead63b5/task/task.ps1#L27

or however, implement what's described here https://github.com/Microsoft/azure-pipelines-task-lib/blob/master/powershell/Docs/FindingFiles.md

Once the search is performed, feed the file to the Pickles param

@dvdvorle
Copy link
Contributor Author

That would indeed make the pattern matching more like other Tasks, I like it. Since Pickles allows mulitiple input files for I'd like to support that as well. I'll look into implementing something later.

@mmajcica
Copy link
Owner

Great. Let me know if you need any help.

mmajcica added a commit that referenced this issue Nov 30, 2018
Fixed #2 - Added file matching support for Test Result File
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants