Update slider range when passing new props #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarkelov
requested changes
Apr 9, 2019
src/index.js
Outdated
| return ( | ||
| !isEqual(nextProps.start, start) || | ||
| nextProps.disabled !== disabled || | ||
| nextProps.range !== range |
There was a problem hiding this comment.
range is object, so it will be always true - and this is not what I actually want.
You can use isEqual from utils, but you should also make some changes to support objects
There was a problem hiding this comment.
Thanks @mmarkelov, sorry for the mistake. I fixed it in the last commit. I used a simple function to compare objects. Maybe in the future it will be interesting to use a more robust method like _.isEqual from lodash.
There was a problem hiding this comment.
@alexmasnou I should think about it. I don't want to include this kind of dependencies and want to make library as simple as possible
|
@alexmasnou Thank you! I'll release new version soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.