Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when setting new range and value #11

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

alexmasnou
Copy link
Contributor

I have noticed that there is an error when updating the range and the value (combined). The error can be reproduced here: https://codesandbox.io/s/0moo1437m0

For solving this error, the range must be updated before changing the 'start' value.

@mmarkelov
Copy link
Owner

@alexmasnou good catch! Thank you!

@mmarkelov mmarkelov merged commit c7178d5 into mmarkelov:master Apr 9, 2019
@alexmasnou
Copy link
Contributor Author

@mmarkelov sorry for bothering you again. I think the last hotfix have an issue with generated assets. The last fix is not working (see https://codesandbox.io/s/7mmmx92830) but the changes are present in source code.

@mmarkelov
Copy link
Owner

@alexmasnou thank you! Find out that there are problems with publishing package.
Version 2.3.3 should be fix it, and I'll find solution to fix these problems.

@shivamragnar
Copy link

shivamragnar commented Dec 3, 2021

I guess this is not yet fixed, having dynamic values for start prop does not seem to be working. My use case has dynamically switching between a range slider with two handles, and normal slider with one handle. Not sure if this is still a bug in here. @mmarkelov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants