Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NouisliderProps.tooltips typing to match noUiSlider docs #24

Merged
merged 2 commits into from Nov 25, 2019

Conversation

wjhurley
Copy link

@wjhurley wjhurley commented Nov 19, 2019

This update changes the typings for NouisliderProps.tooltips to match the noUiSlider docs. I have tested these typings against nouislider-react ^3.3.5 to ensure they pass TSlint checks and that there are no compile-time or run-time errors. I tested the Formatter type using wnumb ^1.2.0 as well as a custom function that returned to and from methods.

I realized after submitting the initial pull request that the types in index.js needed to be updated as well as the github.io page. I've updated those files as well and ran yarn test, which passed all tests.

@mmarkelov
Copy link
Owner

@wjhurley lgtm. Thanks!

@mmarkelov mmarkelov merged commit cdef26b into mmarkelov:master Nov 25, 2019
@wjhurley wjhurley deleted the fix-tooltips-typing branch November 25, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants