Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Workflow #216

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Add GitHub Workflow #216

wants to merge 17 commits into from

Conversation

eyllanesc
Copy link

@eyllanesc eyllanesc commented Mar 16, 2022 •
edited

You have to add the PyPi token to secrets.PYPI_TOKEN (See https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-an-environment).

@eyllanesc eyllanesc force-pushed the github-workflow branch 2 times, most recently from 8094e93 to 4f24043 Compare March 17, 2022 03:48
@eyllanesc eyllanesc mentioned this pull request Mar 17, 2022
Open
@eyllanesc eyllanesc changed the title Add github workflow Add GitHub Workflow Mar 17, 2022
@eyllanesc eyllanesc mentioned this pull request Mar 17, 2022
Open
mmatl
mmatl reviewed Apr 30, 2022
View reviewed changes
Copy link
Owner

@mmatl mmatl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing, thanks for all the work on it! Will get it merged soon. Thanks for your patience -- I've been a bit busy at work and haven't been able to keep up with PRs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatl mmatl mmatl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trimesh 3.9.33 test regression UnboundLocalError: local variable 'e' referenced before assignment
2 participants
@eyllanesc @mmatl