Fix mesh materials not getting loaded properly. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input argument `material` was getting overwritten in the loop so when multiple meshes with different materials were present the logic thought that a material override had been passed. Fixed by renaming inner loop variable and making a deep copy if the passed in material is used.
mikedh
reviewed
Aug 23, 2019
| @@ -305,9 +308,15 @@ def _get_trimesh_props(mesh, smooth=False): | |||
| alphaCutoff=mat.alphaCutoff | |||
| ) | |||
| elif isinstance(mat, trimesh.visual.texture.SimpleMaterial): | |||
There was a problem hiding this comment.
Hey, I recently added a SimpleMaterial.to_pbr method that might be useful for this too, so GLB exports of OBJ imports look nice. That glossiness/roughness conversion looks great, is there a reference for that somewhere? I'd love to add better logic to to_pbr.
There was a problem hiding this comment.
Here are the references I used for this conversion. It seems like there's no real standard conversion but a best effort to try to get the curves to line up.
http://graphicrants.blogspot.com/2013/08/specular-brdf-reference.html
https://computergraphics.stackexchange.com/questions/1515/what-is-the-accepted-method-of-converting-shininess-to-roughness-and-vice-versa
mmatl
approved these changes
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input argument
materialwas getting overwritten in the loop sowhen multiple meshes with different materials were present the logic
thought that a material override had been passed.
Fixed by renaming inner loop variable and making a deep copy if the
passed in material is used.
Fixed at least some causes of #23