Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double Encoding of Query Parameters #152

Closed
pkgulati opened this issue Feb 4, 2019 · 3 comments
Closed

Double Encoding of Query Parameters #152

pkgulati opened this issue Feb 4, 2019 · 3 comments
Labels

Comments

@pkgulati
Copy link

pkgulati commented Feb 4, 2019

When a space character is used in query parameter value, and query is saved and executed later, it is sending %2520. Actually it is encoding two times, first to %20, and then later storing it is %20, and then doing second encoding to %2520.

@mmattozzi
Copy link
Owner

Good catch! In fact this is happening even without saving...

@mmattozzi mmattozzi added the bug label Feb 9, 2019
mmattozzi added a commit that referenced this issue Feb 16, 2019
… copying from the URL Parameters table to the URL
@mmattozzi
Copy link
Owner

Hello. Sorry it took me so long to get back to this, hopefully you're game to discuss it a bit more. I checked in an update that basically removes the double percent encoding. However, this creates what also might be an interesting experience in that if you truly want spaces in your parameters, you'll never see the %20 encoding at all. I've attached what this looks like:

screen shot 2019-02-16 at 10 11 09 am

As you can see, in the parameters table and the URL box itself, a space is just a space (not percent encoded when displayed to the user). However, the target server gets sent a %20 as one would expect. I think this is probably the only sane way to manage this scenario, otherwise it's not really possible to tell the difference between an intended %20 (as unlikely as it is) and when the user was just trying to account for URL encoding on their own.

@mmattozzi
Copy link
Owner

Fixed in Release 1.4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants