Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for age rating metadata #941

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JeffersonBledsoe
Copy link
Contributor

Closes #938

@JeffersonBledsoe
Copy link
Contributor Author

@mmatyas Am I on the right track with this PR? If so, I'll try add support for any other platforms/ providers which could provide age info (I'd have to do some research into which ones do)

@mmatyas
Copy link
Owner

mmatyas commented Feb 15, 2022

The implementation in general looks good, what I'm thinking about is how this should be stored in the metadata files and how should be presented to themes.

I've just looked into the various rating systems, and while there are large variations and overlapping in the categories (eg. Australia's G/PG), it seem they can be largely reduced to a minimal age in all common cases. If we're talking about an age rating, and not purely content ratings, like Hong Kong's I/II/III, and we assume there's no upper limit on the rating, then we can reduce the field's type to an integer, as a minimal recommended age. This would also allow themes to assign some symbols (eg. PEGI icons) for the value.

Alternatively, it could be a string list, similar to eg. Kodi, where each entry is in the form Country:Rating, eg. Australia:PG. This would be probably the most precise solution, but likely an overkill, because you usually already know which region your own game is from. This would also mean more work for themes.

As for the name of the field, I think ageRating could work there too, both the API side and in the metadata file (as it's not the game's age, but its age rating we're showing there).

@mmatyas
Copy link
Owner

mmatyas commented Feb 15, 2022

tl;dr: For now use int as type and call it age rating everywhere (or if you have a good idea for a name that expresses it's the minimal age, that's even better).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Age rating as a built-in metadata
2 participants