Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added customizations possibilities #4

Merged
merged 5 commits into from
Oct 12, 2016
Merged

Added customizations possibilities #4

merged 5 commits into from
Oct 12, 2016

Conversation

Okipa
Copy link

@Okipa Okipa commented Oct 12, 2016

Hi mmazzarolo,

According to the issue I have posted this morning (#3), here is a pull request that should let users do what they want now.

I didn't gave the possibility to show or not the cancel button. If you want to add this feature, that could be nice.

I'm just not sure about the PropTypes.number I set for the awaited Stylesheet objects for te props titleContainerStyleIOS, titleStyleIOS, ... It let you check this.

I also updated the readme.

Let me know if you find any problem.
Thanx for your work !

@mmazzarolo
Copy link
Owner

Man that's awesome!
Thank you for your pull request, did you already test it? :)
Just one nitpick: can you set the styles proptypes to the more appropriate View.propTypes.style?

confirmButtonTextStyleIOS: PropTypes.number,
cancelButtonStyleIOS: PropTypes.number,
cancelButtonTextStyleIOS: PropTypes.number
titleContainerStyleIOS: PropTypes.style,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, it should be View.propTypes.style 👍

@Okipa
Copy link
Author

Okipa commented Oct 12, 2016

Ok, that should be good now.
I tested it and I found no problem.

@mmazzarolo mmazzarolo merged commit d4b8398 into mmazzarolo:master Oct 12, 2016
@mmazzarolo
Copy link
Owner

Merged! I'll try to release this version on npm this evening 👍

@Okipa
Copy link
Author

Okipa commented Oct 12, 2016

Nice, thanx.
Last improvement you could add (I just saw it) : adding the following styles in the titleContainer in CustomDatePickerIOS > index.style.js

borderTopLeftRadius: BORDER_RADIUS,
borderTopRightRadius: BORDER_RADIUS

If a background color is set on the title, its borders have currently no radius.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants