fix: Remove date parameter from onCancel #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @robert-nash ! |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2023
# [16.0.0](v15.0.1...v16.0.0) (2023-06-26) ### Bug Fixes * Remove date parameter from onCancel ([#711](#711)) ([947614a](947614a)) ### BREAKING CHANGES * This is a breaking change since it might people using the `onCancel` parameter in weird ways.
|
🎉 This PR is included in version 16.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As discussed in #709 onCancel does not have any parameters. This pull request corrects the typings to reflect this
Test Plan
Compiles successfully