Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No safearea on IOS #715

Closed
wants to merge 3 commits into from
Closed

Conversation

fahridev
Copy link

@fahridev fahridev commented Jul 31, 2023

Overview

Test Plan

Screen Shot 2023-07-31 at 11 29 21

@fahridev fahridev mentioned this pull request Jul 31, 2023
@mmazzarolo
Copy link
Owner

Maybe I'm out of the loop here, but why do we need to put the SafeAreaView component inside this library? Can't you add it at the top level in your app instead?

@fahridev
Copy link
Author

fahridev commented Aug 3, 2023

Since this error is only on the ios side, I applied it to this component. If we do it to other parties, I did it like this so that it wouldn't give a margin - padding error. @mmazzarolo

@thomasgallagher
Copy link

Same issue here, even though the component is nested in a SafeAreaProvider, it still shows outside of the safe area.

Screenshot 2023-08-09 at 22 14 28

@mmazzarolo
Copy link
Owner

Closed in favor of #718

@mmazzarolo mmazzarolo closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants