Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting #81

Open
wants to merge 91 commits into
base: master
Choose a base branch
from
Open

Reporting #81

wants to merge 91 commits into from

Conversation

mmcc007
Copy link
Owner

@mmcc007 mmcc007 commented Dec 2, 2019

Usage analytics and crash reporting ala Flutter Tools
Also

  • tool version management
  • separated main command line functions into commands with options
  • build on cirrus also (unit tests are faster)
  • moved reporting into separate package with option for custom dimensions
  • added ToolVersion to tool_base package to get remote version and version date from pub.dev (instead of using git which is not available)

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #81 into master will decrease coverage by 22.37%.
The diff coverage is 54.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #81       +/-   ##
===========================================
- Coverage   87.97%   65.59%   -22.38%     
===========================================
  Files          12       21        +9     
  Lines         607     1215      +608     
===========================================
+ Hits          534      797      +263     
- Misses         73      418      +345
Impacted Files Coverage Δ
lib/src/base/utils.dart 87.93% <ø> (-0.41%) ⬇️
lib/src/base/user_messages.dart 1.88% <1.88%> (ø)
lib/src/base/custom_dimensions.dart 100% <100%> (ø)
lib/src/sylph_run.dart 81.73% <100%> (-0.57%) ⬇️
lib/src/commands/devices.dart 100% <100%> (ø)
lib/src/bundle.dart 95.65% <100%> (-4.35%) ⬇️
lib/src/resources.dart 80.35% <100%> (-19.65%) ⬇️
lib/src/validator.dart 76.66% <100%> (ø) ⬆️
lib/src/context_runner.dart 35% <30%> (-1.37%) ⬇️
lib/src/base/runner/sylph_command_runner.dart 48.27% <48.27%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908b4ab...e00aae8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant