Include time zone in generated post metadata #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using the time stamp, with zone, in the RSS feed, and if the zone isn't provided, it assumes UTC and posts get backdated by 4 hours
1 similar comment
|
Good idea...thank you! |
|
My pleasure! Sorry I didn't notice the failing test, thanks for fixing that 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I think it makes sense to include the time zone in the generated timestamp for a post.
I just noticed that because I hadn't been including them, my blog's RSS feed was assuming the times were in UTC, so it had some incorrect / backdated times.
An alternate approach could be to include the current time in UTC, but I think this makes more sense.