Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is desirable, but I've been having trouble with the exceptions I've been getting from lein-difftest, and I think I tracked it back to clj-stacktrace.
Without my changes, the behavior looks like this:
user=> (use 'clj-stacktrace.repl)
nil
user=> (pst (RuntimeException. "foo" (RuntimeException. "bar")))
foo
NO_SOURCE_FILE:4 user/eval134
Compiler.java:5424 clojure.lang.Compiler.eval
Compiler.java:5391 clojure.lang.Compiler.eval
core.clj:2382 clojure.core/eval
main.clj:183 clojure.main/repl[fn]
main.clj:204 clojure.main/repl[fn]
main.clj:204 clojure.main/repl
RestFn.java:422 clojure.lang.RestFn.invoke
NO_SOURCE_FILE:1 user/eval13[fn]
AFn.java:24 clojure.lang.AFn.run
Thread.java:662 java.lang.Thread.run
Caused by: bar
nil
With my changes, the behavior looks like this:
user=> (use 'clj-stacktrace.repl)
nil
user=> (pst (RuntimeException. "foo" (RuntimeException. "bar")))
java.lang.RuntimeException: foo
NO_SOURCE_FILE:4 user/eval136
Compiler.java:5424 clojure.lang.Compiler.eval
Compiler.java:5391 clojure.lang.Compiler.eval
core.clj:2382 clojure.core/eval
main.clj:183 clojure.main/repl[fn]
main.clj:204 clojure.main/repl[fn]
main.clj:204 clojure.main/repl
RestFn.java:422 clojure.lang.RestFn.invoke
NO_SOURCE_FILE:1 user/eval13[fn]
AFn.java:24 clojure.lang.AFn.run
Thread.java:662 java.lang.Thread.run
Caused by: java.lang.RuntimeException: bar
nil
user=>
I'm not entirely sure I understand where things went wrong, as it looks in the README like the classnames are supposed to be there to begin with, but I haven't been able to get clj-stacktrace to give me them.
Feel free to point out if I've misunderstood something, or if you have any criticism.
Side note to Mark: I met you briefly at the conj, and enjoyed your talk.