Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classnames of exceptions #1

Merged
1 commit merged into from Nov 17, 2010
Merged

Add classnames of exceptions #1

1 commit merged into from Nov 17, 2010

Conversation

joegallo
Copy link
Contributor

@joegallo joegallo commented Nov 3, 2010

I'm not sure if this is desirable, but I've been having trouble with the exceptions I've been getting from lein-difftest, and I think I tracked it back to clj-stacktrace.

Without my changes, the behavior looks like this:
user=> (use 'clj-stacktrace.repl)
nil
user=> (pst (RuntimeException. "foo" (RuntimeException. "bar")))
foo
NO_SOURCE_FILE:4 user/eval134
Compiler.java:5424 clojure.lang.Compiler.eval
Compiler.java:5391 clojure.lang.Compiler.eval
core.clj:2382 clojure.core/eval
main.clj:183 clojure.main/repl[fn]
main.clj:204 clojure.main/repl[fn]
main.clj:204 clojure.main/repl
RestFn.java:422 clojure.lang.RestFn.invoke
NO_SOURCE_FILE:1 user/eval13[fn]
AFn.java:24 clojure.lang.AFn.run
Thread.java:662 java.lang.Thread.run
Caused by: bar
nil

With my changes, the behavior looks like this:
user=> (use 'clj-stacktrace.repl)
nil
user=> (pst (RuntimeException. "foo" (RuntimeException. "bar")))
java.lang.RuntimeException: foo
NO_SOURCE_FILE:4 user/eval136
Compiler.java:5424 clojure.lang.Compiler.eval
Compiler.java:5391 clojure.lang.Compiler.eval
core.clj:2382 clojure.core/eval
main.clj:183 clojure.main/repl[fn]
main.clj:204 clojure.main/repl[fn]
main.clj:204 clojure.main/repl
RestFn.java:422 clojure.lang.RestFn.invoke
NO_SOURCE_FILE:1 user/eval13[fn]
AFn.java:24 clojure.lang.AFn.run
Thread.java:662 java.lang.Thread.run
Caused by: java.lang.RuntimeException: bar
nil
user=>

I'm not entirely sure I understand where things went wrong, as it looks in the README like the classnames are supposed to be there to begin with, but I haven't been able to get clj-stacktrace to give me them.

Feel free to point out if I've misunderstood something, or if you have any criticism.

Side note to Mark: I met you briefly at the conj, and enjoyed your talk.

@mmcgrana
Copy link
Owner

mmcgrana commented Nov 4, 2010

Yeah, looks like class names got lost at some point. I need to get a chunk of time to dig into the details, but barring any surprises I should get this merged soon.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants