Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add myself to footer #386

Merged
merged 2 commits into from Aug 26, 2021
Merged

Add myself to footer #386

merged 2 commits into from Aug 26, 2021

Conversation

eliben
Copy link
Collaborator

@eliben eliben commented Aug 26, 2021

No description provided.

@eliben eliben requested a review from mmcgrana August 26, 2021 03:01
@mmcgrana
Copy link
Owner

Content looks good, though you also need to add this to template.tmpl. Sorry that's not obvious because I had duplication between the footers in these. If you feel inspired to fix that duplication feel free, otherwise fine to just copy-paste and rebuild.

@eliben
Copy link
Collaborator Author

eliben commented Aug 26, 2021

Oops. Pushed with the change to example.tmpl as well, and a rebuild.

Will fix the duplication at some later point. Opened #387 to track this

@mmcgrana mmcgrana merged commit 7a5cb99 into master Aug 26, 2021
@eliben eliben deleted the footer branch September 2, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcgrana mmcgrana mmcgrana approved these changes

Assignees

@eliben eliben

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliben @mmcgrana