Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nodejs fs module deprecation (DEP0013) #9

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Fix nodejs fs module deprecation (DEP0013) #9

merged 1 commit into from
Dec 5, 2019

Conversation

siebertm
Copy link
Contributor

This fixes "DEP0013: fs asynchronous function without callback", by calling fs.write() with a callback

@siebertm
Fix nodejs fs module deprecation
0a47e88 
This fixes "DEP0013: fs asynchronous function without callback", by calling `fs.write()` with a callback
@bischofs1337
Copy link

Hello,

Just pinging in to know if the repo is still maintained as the PR has been opened for quite some time and is still not accepted. This is sad because the PR really fixes the issue.

@mmckegg your feedback is very welcome.
@siebertm Thanks for the fix :-)

Regards,

Sébastien

@rmp rmp merged commit 8971338 into mmckegg:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cynicer cynicer cynicer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siebertm @bischofs1337 @cynicer @rmp