Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install.sh: script broken #144

Closed
mmcloughlin opened this issue Jan 28, 2023 · 2 comments
Closed

install.sh: script broken #144

mmcloughlin opened this issue Jan 28, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mmcloughlin
Copy link
Owner

Install test failed:

https://github.com/mmcloughlin/addchain/actions/runs/4030515351/jobs/6929229953

Running locally:

mbm@xps ~/D/addchain (master)> ./install.sh
mmcloughlin/addchain info checking GitHub for latest tag
mmcloughlin/addchain info found version:  <!DOCTYPE html> <html lang= for  <!DOCTYPE html> <html lang=/linux/amd64
@mmcloughlin mmcloughlin added the bug Something isn't working label Jan 28, 2023
@mmcloughlin
Copy link
Owner Author

Seems to be the same underlying github issue that caused the golangci-lint install to break:

golangci/golangci-lint#3509
golangci/golangci-lint#3510

@mmcloughlin
Copy link
Owner Author

It seems Github fixed the underlying issue:

https://github.com/orgs/community/discussions/45590#discussioncomment-4802887

Builds pass now:

https://github.com/mmcloughlin/addchain/actions/runs/4030515351/
https://github.com/mmcloughlin/addchain/actions/runs/4030504789/

mmcloughlin added a commit that referenced this issue Jan 28, 2023
@mmcloughlin
Revert "script: fix golangci-lint install (#143)"
86a0981 
This reverts commit a2229ff.

It seems Github fixed the underlying issue:

https://github.com/orgs/community/discussions/45590#discussioncomment-4802887

Updates #144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmcloughlin