Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/addchain: search options to modify costs #120

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Conversation

mmcloughlin
Copy link
Owner

Doubling (squaring) is typically cheaper than addition (multiplication). This
PR adds options to the search subcommand to score addition chains based on a
weighted sum.

Closes #55
Updates #117

@codecov-commenter
Copy link

Codecov Report

Merging #120 (32fccb5) into master (af1add4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   73.05%   73.05%           
=======================================
  Files          30       30           
  Lines        1874     1874           
=======================================
  Hits         1369     1369           
  Misses        445      445           
  Partials       60       60           
Flag Coverage Δ
stress ?
unittests 73.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af1add4...32fccb5. Read the comment docs.

@mmcloughlin mmcloughlin merged commit 881e229 into master Oct 9, 2021
@mmcloughlin mmcloughlin deleted the search-costs branch October 9, 2021 18:18
@armfazh
Copy link

armfazh commented Oct 9, 2021

These changes look good, a validation that the costs are non-negative could be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorporate add/double weighting in chain cost
3 participants