Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ir,build: add support for comments #41

Closed
mmcloughlin opened this issue Jan 7, 2019 · 1 comment
Closed

ir,build: add support for comments #41

mmcloughlin opened this issue Jan 7, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@mmcloughlin
Copy link
Owner

It would be good to support comments in the output. At the moment it is natural to have comments in the generator:

avo/examples/sha1/asm.go

Lines 21 to 28 in 022d24d

// Load initial hash.
h0, h1, h2, h3, h4 := GP32(), GP32(), GP32(), GP32(), GP32()
MOVL(h.Offset(0), h0)
MOVL(h.Offset(4), h1)
MOVL(h.Offset(8), h2)
MOVL(h.Offset(12), h3)
MOVL(h.Offset(16), h4)

This could just as well be replaced with Comment("Load initial hash") and it would serve to document the generator and the output.
@mmcloughlin mmcloughlin added the enhancement New feature or request label Jan 7, 2019
mmcloughlin added a commit that referenced this issue Jan 11, 2019
@mmcloughlin
build: support comments in functions (#41)
284ee13
mmcloughlin added a commit that referenced this issue Jan 11, 2019
@mmcloughlin
build: Commentf function
9403305 
Convenience for adding a comment generated with fmt.Sprintf.

Updates #41
mmcloughlin added a commit that referenced this issue Jan 11, 2019
@mmcloughlin
examples/sha1: use comments (#41)
d0357fa
mmcloughlin added a commit that referenced this issue Jan 11, 2019
@mmcloughlin
examples/sum: use Comment (#41)
3ca82be
mmcloughlin added a commit that referenced this issue Jan 11, 2019
@mmcloughlin
examples/sum: attempt to avoid asmfmt mismatch
943d5f0 
Updates #41
Updates #8
@mmcloughlin
Copy link
Owner Author

Consider this done. #8 remains open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmcloughlin