Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: remove +build tags #377

Merged
merged 1 commit into from
Mar 6, 2023
Merged

all: remove +build tags #377

merged 1 commit into from
Mar 6, 2023

Conversation

mmcloughlin
Copy link
Owner

@mmcloughlin mmcloughlin commented Mar 6, 2023

Commit 759be3d bumped our Go requirement to 1.18 which allows us to drop support for old-style +build tags. This change runs go fix ./... to remove them, and updates some remaining code generators that produced +build lines.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #377 (c7ad890) into master (759be3d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   78.13%   78.12%   -0.02%     
==========================================
  Files          99       99              
  Lines       23724    23728       +4     
==========================================
  Hits        18537    18537              
- Misses       5091     5095       +4     
  Partials       96       96              
Flag Coverage Δ
integration 22.05% <0.00%> (-0.01%) ⬇️
unittests 73.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
examples/add/asm.go 100.00% <ø> (ø)
examples/args/asm.go 100.00% <ø> (ø)
examples/complex/asm.go 100.00% <ø> (ø)
examples/data/asm.go 100.00% <ø> (ø)
examples/dot/asm.go 100.00% <ø> (ø)
examples/ext/asm.go 100.00% <ø> (ø)
examples/fnv1a/asm.go 100.00% <ø> (ø)
examples/geohash/asm.go 100.00% <ø> (ø)
examples/md5x16/asm.go 100.00% <ø> (ø)
examples/pragma/asm.go 100.00% <ø> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mmcloughlin mmcloughlin mentioned this pull request Mar 6, 2023
@mmcloughlin mmcloughlin changed the title all: require go 1.18 and remove +build tags all: remove +build tags Mar 6, 2023
@mmcloughlin mmcloughlin marked this pull request as ready for review March 6, 2023 04:12
@mmcloughlin mmcloughlin merged commit 34ac353 into master Mar 6, 2023
@mmcloughlin mmcloughlin deleted the go-fix-buildtag branch March 6, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants