New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent line breaking between FontAwesome icon and text in footer social links #1659

Closed
tlindsay42 opened this Issue May 8, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@tlindsay42
Contributor

tlindsay42 commented May 8, 2018

Description

Line breaking between the FontAwesome icon and text does not normally occur in the footer social link list, but it did on my site when I added a Travis CI build badge to the list on my custom footer.html override page. Adding a span to each like in social-share.html would help maintain the look & feel of the theme should other users choose to make a similar customization.

Environment


Expected behavior

Line breaking between the FontAwesome icons and text in footer social links should not occur.

Steps to reproduce the behavior

I added a Travis CI build badge as a list item with right alignment to the footer social link list and...

image.

Again, not the most common use case, but this change would help maintain the look and feel of the theme when users make similar customizations.

Pull Request following momentarily.

tlindsay42 added a commit to tlindsay42/minimal-mistakes that referenced this issue May 8, 2018

tlindsay42 added a commit to tlindsay42/minimal-mistakes that referenced this issue May 8, 2018

tlindsay42 added a commit to tlindsay42/minimal-mistakes that referenced this issue May 8, 2018

tlindsay42 added a commit to tlindsay42/minimal-mistakes that referenced this issue May 9, 2018

tlindsay42 added a commit to tlindsay42/minimal-mistakes that referenced this issue May 9, 2018

@tlindsay42

This comment has been minimized.

Contributor

tlindsay42 commented May 11, 2018

Yeesh. I am obviously inexperienced at removing previously pushed commits. I thought a hard reset and force push on the branch would do the trick, but was obviously wrong. I also tried a rebase -i, but must have been doing something wrong. Any suggestions @mmistakes? Also, does f5a7a13 look okay?

@tlindsay42

This comment has been minimized.

Contributor

tlindsay42 commented May 11, 2018

nm. Just checked the PR and I think that it looks right.

mmistakes added a commit that referenced this issue May 11, 2018

luispuerto referenced this issue in luispuerto/luispuerto.net Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment