New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of contents missing border between last parent header and all children #1675

Closed
tlindsay42 opened this Issue May 15, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@tlindsay42
Contributor

tlindsay42 commented May 15, 2018

Description

The table of contents does not display the border between the last parent header (<h2>) cell and all subsequent children (<h3>). This behavior occurs whether in standard or wide mode, for all skins tested, as well as for both pages & posts.

Environment

  • Minimal Mistakes version:
  • Ruby gem or remote theme version:
  • Jekyll version:
Get-Content -Path .\Gemfile.lock | Select-String -Pattern '^\s{4}(?:jekyll(?:\s|-remote-theme)|minimal-mistakes-jekyll)'

    jekyll (3.7.3)
    jekyll-remote-theme (0.2.3)
    minimal-mistakes-jekyll (4.11.2)

Expected behavior

The same border should be drawn between the last two cells as surrounds all of the other cells.

Steps to reproduce the behavior

Control 1

  1. Create a page or post with a table of contents (example)
  2. Enter a few test headers with the last header being a parent (<h2>)
  3. Serve - the issue will not appear

image

Control 2

  1. Set classes: 'wide' in the front matter
  2. The issue will not appear

image

Test 1

  1. Change the last header to a child (<h3>)
  2. The border will be missing between the last parent and its child header in the table of contents

image

Test 2

  1. Comment out classes: 'wide' in the front matter

image

Test 3

  1. Add another child header (<h3>)

image

Test 4

  1. Re-enable classes: 'wide' in the front matter

image

@mmistakes

This comment has been minimized.

Owner

mmistakes commented May 15, 2018

Looks like this CSS doesn't cover all possible combinations of nested list items.

I was using it to remove the last item's border so there wasn't a thicker one at the bottom, but I think it's safe to remove it all together. Then all list items correctly get a border-bottom.

@mmistakes mmistakes closed this in f031c08 May 15, 2018

luispuerto referenced this issue in luispuerto/luispuerto.net Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment