New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navtoogle or navtoggle in scss? #175

Closed
logista opened this Issue Aug 18, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@logista

logista commented Aug 18, 2015

I was trying to modify the color of the menu button, and found its class is .navtoogle (which is also what it's called in the javascripts)

But page.scss also has .navtoggle

.no-js .nav .navtoggle {
    display: none;
}

I'm assuming this wants to be .navtoogle to match?

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 18, 2015

Owner

Line 171 in page.scss is where you can change the color and/or styling of the menu button that appears on smaller devices.

Owner

mmistakes commented Aug 18, 2015

Line 171 in page.scss is where you can change the color and/or styling of the menu button that appears on smaller devices.

@logista

This comment has been minimized.

Show comment
Hide comment
@logista

logista Aug 18, 2015

Got it. Thanks!

But I should have been more explicit about my question: is the typo in navtoogle (two o) or in navtoggle (two g) or there isn't a typo or it doesn't matter?

(I'm a photographer, not a coder; I only know enough to get myself in trouble)

logista commented Aug 18, 2015

Got it. Thanks!

But I should have been more explicit about my question: is the typo in navtoogle (two o) or in navtoggle (two g) or there isn't a typo or it doesn't matter?

(I'm a photographer, not a coder; I only know enough to get myself in trouble)

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 18, 2015

Owner

Looks like it's a typo. Should be navtoggle in the CSS and in the HTML.

Owner

mmistakes commented Aug 18, 2015

Looks like it's a typo. Should be navtoggle in the CSS and in the HTML.

@mmistakes mmistakes self-assigned this Aug 18, 2015

@mmistakes mmistakes added the Type: Bug label Aug 18, 2015

@mmistakes mmistakes closed this in d5a0a2e Aug 19, 2015

mmistakes added a commit that referenced this issue Aug 19, 2015

Fix typo in menu button class
- .navtoogle should be .navtoggle
- Fixes #175

mmistakes added a commit that referenced this issue Aug 19, 2015

Fix typo in menu button class
- .navtoogle should be .navtoggle
- Fixes #175

davet321 added a commit to davet321/pgrs2 that referenced this issue Feb 15, 2016

Fix typo in menu button class
- .navtoogle should be .navtoggle
- Fixes mmistakes#175

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017

Fix typo in menu button class
- .navtoogle should be .navtoggle
- Fixes mmistakes#175

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this issue Jul 27, 2018

Fix typo in menu button class
- .navtoogle should be .navtoggle
- Fixes mmistakes#175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment