New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigation links sidebar overlays main body text on small screens #396

Closed
casa-albore opened this Issue Jul 13, 2016 · 9 comments

Comments

Projects
None yet
3 participants
@casa-albore
Copy link

casa-albore commented Jul 13, 2016

  • This is a question about using the theme.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

Expected behavior

navigation sidebar either disappears when screen too narrow or scrolls away as the page is scrolled, does not overlay text from main page

Steps to reproduce the behavior

Visit the below page on a smaller width screen and scroll down a little:

https://mmistakes.github.io/minimal-mistakes/docs/quick-start-guide/

The navigation sidebar text overlays the main text.

I'd personally prefer the navigation text to be hidden when the screen is too narrow (navigation is possible from elsewhere anyway)...

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Jul 14, 2016

Can you attach a screenshot of the overlap? I'm not seeing it.

@casa-albore

This comment has been minimized.

Copy link

casa-albore commented Jul 14, 2016

here's a screenshot with chrome/mac:

screen shot 2016-07-14 at 08 00 03

The same issue occurs on my android phone. It doesn't reproduce on firefox/mac or safari/mac

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Jul 14, 2016

Ah yeah I see it. It's related to a pull request @ZenHarbinger submitted to cleanup the sidebar c3e2272

There's a bit of JavaScript in there that's probably not triggering properly on the custom sidebar shown in the Documentation section of the site.

Definitely a bug.

@mmistakes mmistakes added the Type: Bug label Jul 14, 2016

@ZenHarbinger

This comment has been minimized.

Copy link
Contributor

ZenHarbinger commented Jul 14, 2016

My bad, I guess there isn't always an author's button and it needs a hard width value. I can see if a better condition can be found.

At least I'm assuming that this situation doesn't have the author button.

I'll look at it when I get a chance.

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Jul 14, 2016

Sounds good. Thanks @ZenHarbinger

And yeah there's no author button on these sorts of sidebars. Pretty sure that's why I originally hard-coded the width in there.

Maybe fallback to that value if the author button isn't present so the sticky sidebar doesn't fire on smaller screens messing with the layout.

@ZenHarbinger

This comment has been minimized.

Copy link
Contributor

ZenHarbinger commented Jul 14, 2016

How do you generate your minimized javascript?

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Jul 14, 2016

@ZenHarbinger

This comment has been minimized.

Copy link
Contributor

ZenHarbinger commented Jul 14, 2016

Awesome, one thing, can you update the page; I instead of

npm build:js

it's

npm run build:js

at least it is for node 6.3, if it's still that for 4.x, nevermind.
That is all, I'm working on this as we speak.

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Jul 14, 2016

Good catch. It's a typo I missed.

mmistakes added a commit that referenced this issue Jul 14, 2016

@mmistakes mmistakes closed this in 8b8885a Jul 14, 2016

sobkowiak added a commit to sobkowiak/sobkowiak.github.io-new that referenced this issue Jul 18, 2016

sobkowiak added a commit to sobkowiak/sobkowiak.github.io-new that referenced this issue Jul 18, 2016

cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this issue Dec 7, 2016

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this issue Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment