Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure helper breaks when using code font in caption combined with popup=true #4841

Closed
ShaneKosieradzki opened this issue May 14, 2024 · 2 comments

Comments

@ShaneKosieradzki
Copy link

What happened?

Expected behavior

When using the figure helper template, the caption attribute is sensitive to use of code text.

What i mean is if you wrap a word in the caption in backticks, than the whole template breaks. This does not seem to happen with other markdown syntax such as italics.

It still displays the figure and caption when you have the code text but it also shows some raw html in the final output website

Steps to reproduce the behavior

To reproduce this error in a markdown file use the figure template and set a caption that has some word wrapped in backticks.

Other

Use this snippet to recreate the error

{% include figure popup=true image_path="/path/to/figure.png" caption="This caption has `code text` which will cause the template to break" %}
@iBug iBug closed this as completed in 4efb863 May 14, 2024
@iBug
Copy link
Collaborator

iBug commented May 14, 2024

Try the latest patch with remote_theme: "mmistakes/minimal-mistakes" (i.e. drop the version number) and see if it's resolved.

@ShaneKosieradzki
Copy link
Author

This resolved the issue thanks!

@iBug iBug changed the title Figure helper breaks when using code font in caption Figure helper breaks when using code font in caption combined with popup=true May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants