Clarify lunr only searches documents in collections #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at-ishikawa
force-pushed
the
update-search-configuration
branch
from
f015503
to
30afd0a
Compare
|
@mmistakes Thank you for adding label. Also, if this PR looks good, what should we do for next? |
|
Nothing to do on your end. I just need time to merge it in and update the change log/history. |
jesuswasrasta
pushed a commit
to jesuswasrasta/jesuswasrasta.github.io
that referenced
this pull request
Jul 8, 2020
mzaffran
pushed a commit
to mzaffran/mzaffran.github.io
that referenced
this pull request
Jan 4, 2021
kaitokikuchi
pushed a commit
to kaitokikuchi/kaitokikuchi.github.io
that referenced
this pull request
Sep 4, 2023
chukycheese
pushed a commit
to chukycheese/chukycheese.github.io
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a documentation change.
Summary
Update documents to clarify Lunr only searches documents in collections or posts.
Context
I'm newbie of jekyll and github pages, and I couldn't figure out why my pages under
/docsdirectories cannot be searched for a couple of hours.So, I think it's gonna be great if we explicit say
documents in collectionscan be searched, so that newbies can understand.Is this related to any GitHub issue(s)?
It looks this PR is related with #1663 (comment)