Enhance Bilibili video support (redo of #2522) #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzaffran
pushed a commit
to mzaffran/mzaffran.github.io
that referenced
this pull request
Jan 4, 2021
* Enhance support for bilibili videos in responsive video helper, and add corresponding doc * Apply @iBug's review in mmistakes#2522 * Fix danmaku in page hero video * Update video to use case..when for iframe src * Update CHANGELOG and history Co-authored-by: Anran <51769728+ALeafWolf@users.noreply.github.com> Co-authored-by: Michael Rose <mmistakes@users.noreply.github.com>
kaitokikuchi
pushed a commit
to kaitokikuchi/kaitokikuchi.github.io
that referenced
this pull request
Sep 4, 2023
* Enhance support for bilibili videos in responsive video helper, and add corresponding doc * Apply @iBug's review in mmistakes#2522 * Fix danmaku in page hero video * Update video to use case..when for iframe src * Update CHANGELOG and history Co-authored-by: Anran <51769728+ALeafWolf@users.noreply.github.com> Co-authored-by: Michael Rose <mmistakes@users.noreply.github.com>
chukycheese
pushed a commit
to chukycheese/chukycheese.github.io
that referenced
this pull request
Sep 18, 2023
* Enhance support for bilibili videos in responsive video helper, and add corresponding doc * Apply @iBug's review in mmistakes#2522 * Fix danmaku in page hero video * Update video to use case..when for iframe src * Update CHANGELOG and history Co-authored-by: Anran <51769728+ALeafWolf@users.noreply.github.com> Co-authored-by: Michael Rose <mmistakes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original author of #2522 hasn't returned to GitHub in more than 2 months, so I'll take the courtesy of completing that PR.
Summary
Basically what's been proposed in the original PR, plus my own review suggestions applied.
Side change
Rewritten
_include/videoto use acase-whenclause for the iframesrcattribute, so other HTML attributes need not repeat for each video provider.Context
#2522