Clarified where to customize scss variables #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation stated that lines to change variable names should be added to main.scss after @import statements. I tried this and it did not work for me. I then added these lines after the import statements and the customization works perfectly. According to [this post](https://stackoverflow.com/questions/17089717/how-to-overwrite-scss-variables-when-compiling-to-css) default variables (such as $accent-color) can be overwritten ahead of time. But changing the value of a variable after it has been used will not have any effect on the earlier parts of the CSS where the variable was used. Therefore, it seems like variables have to be overwritten after the import statements, and there is no way to overwrite variables that were not declared with !default.
|
Good catch. Thanks! |
|
No problem! Thank you for making this great theme! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation stated that lines to change variable names should be added to main.scss after @import statements. I tried this and it did not work for me.
I then added these lines after the import statements and the customization works perfectly.
According to this post default variables (such as $accent-color) can be overwritten ahead of time. But changing the value of a variable after it has been used will not have any effect on the earlier parts of the CSS where the variable was used.
Therefore, it seems like variables have to be overwritten after the import statements, and there is no way to overwrite variables that were not declared with !default.