Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version from bundler dependency #362

Merged
merged 3 commits into from Feb 25, 2020
Merged

Remove version from bundler dependency #362

merged 3 commits into from Feb 25, 2020

Conversation

sachinsshetty
Copy link
Contributor

This is a bug fix

Summary

Solve bundler version conflict on 'jekyll serve' command execution

Context

Latest bundler version is "2.1.2"

Local bundle installation fails as gemspec is pointing to previous version - "2.0.2".

@sachinsshetty
Copy link
Contributor Author

This is PR for issue #363

PR also has commit for locale support for Kannada (kn)

@mmistakes
Copy link
Owner

Could you remove the translation text data file from this pull request and make it's own?

@@ -22,6 +22,6 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency "jekyll-feed", "~> 0.1"
spec.add_runtime_dependency "jekyll-seo-tag", "~> 2.4"

spec.add_development_dependency "bundler", "~> 2.0.2"
spec.add_development_dependency "bundler", "~> 2.1.2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the version all together... there's no need for it. The following should suffice:

spec.add_development_dependency "bundler"

@sachinsshetty sachinsshetty reopened this Jan 16, 2020
@mmistakes mmistakes changed the title update to bunlder version: 2.1.2 Remove version from bundler dependency Jan 16, 2020
@mmistakes mmistakes merged commit 8d90e96 into mmistakes:master Feb 25, 2020
clarafy pushed a commit to clarafy/clarafy.github.io that referenced this pull request Mar 24, 2021
Remove version from bundler dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants