-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
please add label->framework #1
Comments
Hi, Kristina Maybe I didn't get you right but I think framework label is already in api:
see index.ts |
Yes, the api label is available. However, I believe this would require each test to use the api pass along the jest label. Is this correct? I am asking for this label to be included in the reports by default, e.g. without any extra config beyond just including/enabling this library. The officially supported allure libraries do this. |
You will NOT need to add framework label to each test. You just need configure your runner once to add this label with any value you want. It can be done like it is said here https://github.com/mmisty/jest-allure2-adapter#custrom-jasmine-reporter (and then you add framework label in specStarted) This library was created because I didn't find anything working with allure 2, so I want to keep flexibility and don't want to hardcode anything. |
Ah, yes, my apologies for saying 'every test'. I meant 'every test suite'. The solution https://github.com/mmisty/jest-allure2-adapter#custrom-jasmine-reporter would certainly work to add arbitrary labels/etc to a report coming from a test suite. If the label was very specific to that test suite, this would be very reasonable. Also I might add, this approach will be very complex to apply to thousands of test suites across hundreds of products. In addition, framework:jest is not an arbitrary label. Again, I am glad to contribute code to this project, if you are open to contributors. java example of the labels:
python:
|
Ok, you've convinced me. I've implemented framework, language and host labels in 0.3.7 version (https://github.com/mmisty/jest-allure2-adapter#037) But JFYI: you will not need to setup label in every test or even in every suite (if by saying 'suite' you mean suite created after using 'describe'), you will just need to create setup file (ex. custom-reporter.ts), do setup like I wrote above and add any label you want by typing one line (and this label will be added to every test in your project) Thank you for this issue =) |
Yay thanks! I am probably not using the term 'test suite' appropriately, so apologies for that. I do follow the setupfile approach and how it will work. I do deal with many, many tests across many repositories. |
Hi there!
My team is looking into using allure reports more broadly - across many test platforms.
The allure report for some frameworks includes the framework name, as in:
It seems this info is hardcoded into the plugin as in this LOC:
https://github.com/allure-framework/allure-java/blob/5365fddefb684ca4d4abd6b43c5ec7b10f2215d3/allure-junit-platform/src/main/java/io/qameta/allure/junitplatform/AllureJunitPlatform.java#L376
Would you be open to including a framework -> jest label in this repo?
I'm open to providing a PR myself or from my team, but I just wanted to float the idea to you first.
The text was updated successfully, but these errors were encountered: